Skip to content

feat: expose MissingFundsErr#107

Merged
ascandone merged 1 commit intomainfrom
feat/expose-errors
Jan 28, 2026
Merged

feat: expose MissingFundsErr#107
ascandone merged 1 commit intomainfrom
feat/expose-errors

Conversation

@ascandone
Copy link
Contributor

@ascandone ascandone commented Jan 28, 2026

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026 •
edited
Loading

Walkthrough

The changes add an Is() method to the MissingFundsErr error type to enable compatibility with errors.Is(), and expose MissingFundsErr as a public API type through package-level aliases for external consumption.

Changes

Cohort / File(s) Summary
Error Handler Implementation
internal/interpreter/interpreter_error.go		 Added Is(target error) bool method to MissingFundsErr type to support errors.Is() error type assertion.
Public API Export
numscript.go		 Exposed MissingFundsErr as a public type alias in multiple type blocks for external package access.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop, a bound, a method new,
Our funds declared for all to view,
With Is() checks so clean and bright,
The errors flow just right,
No missing coin shall hide from sight! 💰

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the rationale for exposing MissingFundsErr and how it benefits users of the package.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: exposing MissingFundsErr as a public API through type aliases and implementing the Is() method for error compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/expose-errors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 28, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.75%. Comparing base (9caec53) to head (95d6ef6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/interpreter/interpreter_error.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   67.84%   67.75%   -0.10%     
==========================================
  Files          45       45              
  Lines        4422     4425       +3     
==========================================
- Hits         3000     2998       -2     
- Misses       1260     1264       +4     
- Partials      162      163       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ascandone ascandone requested a review from gfyrag January 28, 2026 16:39
@ascandone ascandone merged commit aee5218 into main Jan 28, 2026
5 of 7 checks passed
@ascandone ascandone deleted the feat/expose-errors branch January 28, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gfyrag gfyrag gfyrag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ascandone @gfyrag